Add rc version to install script before tag #405
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 33af1ecbc87b0a0b65245083 |
alocay
changed the title
swcollard
reviewed
Oct 1, 2025
| CURR_VERSION: ${{ steps.meta.outputs.rc_version != '' && steps.meta.outputs.rc_version || steps.meta.outputs.current_version }} | ||
| NEW_VERSION: ${{ steps.bump.outputs.new_version }} | ||
| run: | | ||
| python3 - <<'PY' |
There was a problem hiding this comment.
This seems copy/pasted from the other step where the RC is generated. It'd be nice if it could be reused and we just pass either the RC version or the new version into it but its probably fine if we want to refactor that later
There was a problem hiding this comment.
Yeah I was considering this as well. Let me see if there a way to do this and update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a step replace install script versions with RC build (if set), commit, push, and then tag. Afterwards it will update the install scripts again with the new release version.